488031 - [fr] Change in searchplugins for Firefox 3.5

Status: VERIFIED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Cédric Corazza]

Attachment: Patch replacing Mediadico for cnrt-tfli

As discussed, here's the patch to remove the Mediadico searchplugin and to add cnrt-tlfi.
I removed all the "os:" references.
I guess we should also send the modified cnrt-tlfi searchplugin to mycroft.mozdev.org once it is in?

Comment 1

[Staś Małolepszy :stas]

Comment on attachment 372290 [details] [diff] [review]
Patch replacing Mediadico for cnrt-tfli

Thanks Cédric. A couple of review comments:

>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/" xmlns:os="http://a9.com/-/spec/opensearch/1.1/">

* you can remove the opensearch namespace, using mozsearch is enough for the plugins we ship with Firefox.

>+<ShortName>CNRTL - TLFi</ShortName>

* the current ShortName is a bit cryptic. Also, http://www.cnrtl.fr/lexicographie/ already has a plug-in (http://www.cnrtl.fr/portail/opensearch.xml) which uses a different name: <ShortName>Portail Lexical - CNRTL</ShortName>. We should use that one to make sure Firefox doesn't offer to install this plugin again when the user is on their website.

>+<UpdateInterval>7</UpdateInterval>
>+<UpdateUrl>http://mycroft.mozdev.org/updateos.php/id0/cnrtl.xml</UpdateUrl>
>+<IconUpdateUrl>http://mycroft.mozdev.org/updateos.php/id0/cnrtl.ico</IconUpdateUrl>

* please remove the update-related elements. Autoupdating the default plugins could cause problems during the software update/upgrade.

Based on the above, that's an r-, but easy to fix :) Please attach a new patch.

We'll need to wait for CNRTL to give their permission before we can land this. Thanks for sending them an e-mail inquiry about that, Cédric. Do you want me to try to contact them too? I'd like to try to get this into beta4, if possible, and for this to happen, we'd need to have the permission by tomorrow.

Comment 2

[Cédric Corazza]

I've got today a reply from the webmaster saying he was on vacation till the end of the week and that he will contact me next week.
So this won't get in FF 3.5b4 unfortunately.

Comment 3

[Cédric Corazza]

Attachment: Patch addressing comment #1

Comment 4

[Staś Małolepszy :stas]

(In reply to comment #2)
> I've got today a reply from the webmaster saying he was on vacation till the
> end of the week and that he will contact me next week.
> So this won't get in FF 3.5b4 unfortunately.

Hey Cédric, did the webmaster eventually get back to you on this? If we're quick, maybe we can still take this in for 3.5. Let me know if I can help by contacting CNRTL.

Comment 5

[Staś Małolepszy :stas]

Hrm, turns out I missed Cédric's e-mail with the permission CNRTL had sent to him. Sorry Cédric. I'll review the patch now.

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 372636 [details] [diff] [review]
Patch addressing comment #1


>+<UpdateUrl>http://mycroft.mozdev.org/updateos.php/id0/cnrtl.xml</UpdateUrl>
>+<IconUpdateUrl>http://mycroft.mozdev.org/updateos.php/id0/cnrtl.ico</IconUpdateUrl>

These lines will be ignored, as we support different ways of updating built-in search engines. So you might want to delete these lines before the landing.

Anyways, r=me. Please land this patch on branch (1.9.1) and trunk (l10n-central) using a descriptive check-in comment, mentioning the bug number and my review (e.g. "Bug 488031: Search engines: remove Mediadico, add CNRTL, r=stas").

Please use fixed1.9.1 and verified1.9.1 keywords in this bug to track landing and verification on the 1.9.1 branch. Also, please make sure you let Axel know what the new opt-in revision. Thanks!

Comment 7

[Cédric Corazza]

Fixed : http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/fr/rev/946fd7dd36a0

Comment 8

[Cédric Corazza]

Verified:
BuildID=20090530031230
Milestone=1.9.1pre
SourceStamp=b4c647c119c6
SourceRepository=http://hg.mozilla.org/releases/mozilla-1.9.1

Comment 9

[Pascal Chevrel:pascalc]

documentation point: the reasons why Mediadico was changed to tlfi were that Mediadico started to put too much advertising on search results coming from Firefox users and cnrt-tlfi provides more complete information in its definitions.