Closed Bug 488037 Opened 15 years ago Closed 13 years ago

certManager accesskey issue

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: dwayne, Assigned: willyaranda)

Details

Attachments

(1 file, 1 obsolete file)

Patch for m-c
1.72 KB, patch
johnath
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review 
The en-US localisation file: security/manager/chrome/pippki/certManager.dtd has one entry with confusing accesskey names.

exceptionMgr.exceptionButton and exceptionMgr.exceptionButtonAccess should be named:

exceptionMgr.exceptionButton.label and exceptionMgr.exceptionButton.assesskey respectively, as is done in the rest of certManager.dtd
Summary: cerManager accesskey issue → certManager accesskey issue
OS: Linux → All
Hardware: x86 → All
Whiteboard: [good first bug]
Version: unspecified → Trunk
Attached patch Patch for 1.9.1 (obsolete) — — Splinter Review 
It is the same for 1.9.2
Attachment #372316 - Flags: review?(l10n)
The chances for this to make it into 1.9.1 are slim, I don't expect to break string freeze for this.
Attachment #372316 - Flags: review?(l10n)
Comment on attachment 372316 [details] [diff] [review]
Patch for 1.9.1

Technically not wrong, but it's going to need a review from a security guy. Good choices should be in the blame for the code in question. Canceling the review request on me.
Attachment #372316 - Flags: review?(rrelyea)
So this patch should be only for 1.9.2?
(In reply to comment #2)
> The chances for this to make it into 1.9.1 are slim, I don't expect to break
> string freeze for this.

I would agree on that call, this is not important enough to break the string freeze
Attachment #372316 - Flags: review?(rrelyea) → review?(kaie)
Is my patch still correct for 1.9.2? I think it should be landed
This is still broken on mozilla-central, can we get this fixed for 2.0?
That'd be a ping for kaie, though it'd help to have a patch that's against mozilla-central instead of 1.9.1.
Comment on attachment 372316 [details] [diff] [review]
Patch for 1.9.1

Maybe Johnath can review this?
Attachment #372316 - Flags: review?(kaie) → review?(johnath)
Attached patch Patch for m-c — — Splinter Review 

        Attachment #372316 -
        Attachment is obsolete: true

        Attachment #472722 -
        Flags: review?(johnath)

        Attachment #372316 -
        Flags: review?(johnath)

    
    

    
  
Review to Johnath, because Ehsah said that!

    
    

    
  
Comment on attachment 472722 [details] [diff] [review]
Patch for m-c

Looks fine but I haven't tested it, so this shouldn't land without someone confirming that the entities all look fine.

Honestly, I think this could have gone in with Axel's okay - there's no change of semantic, here. Anyhow - if it works, it wfm.

        Attachment #472722 -
        Flags: review?(johnath) → review+

    
    

    
  
Comment on attachment 472722 [details] [diff] [review]
Patch for m-c

Requesting approval for 2.0.

It does have string impact, but only small and it eases life for a significant part of our community that work on toolchains that do magic for accesskeys.

        Attachment #472722 -
        Flags: approval2.0?

    
    

    
  
Comment on attachment 472722 [details] [diff] [review]
Patch for m-c

Gavin says he'll land this before b7. Not approved after b7.

        Attachment #472722 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fbf93302de79
Assignee: kaie → willyaranda
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → mozilla2.0b7
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.