488037 - certManager accesskey issue

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Dwayne Bailey]

The en-US localisation file: security/manager/chrome/pippki/certManager.dtd has one entry with confusing accesskey names.

exceptionMgr.exceptionButton and exceptionMgr.exceptionButtonAccess should be named:

exceptionMgr.exceptionButton.label and exceptionMgr.exceptionButton.assesskey respectively, as is done in the rest of certManager.dtd

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for 1.9.1

It is the same for 1.9.2

Comment 2

[Axel Hecht [:Pike]]

The chances for this to make it into 1.9.1 are slim, I don't expect to break string freeze for this.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 372316 [details] [diff] [review]
Patch for 1.9.1

Technically not wrong, but it's going to need a review from a security guy. Good choices should be in the blame for the code in question. Canceling the review request on me.

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

So this patch should be only for 1.9.2?

Comment 5

[Dwayne Bailey]

(In reply to comment #2)
> The chances for this to make it into 1.9.1 are slim, I don't expect to break
> string freeze for this.

I would agree on that call, this is not important enough to break the string freeze

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

Is my patch still correct for 1.9.2? I think it should be landed

Comment 7

[Dwayne Bailey]

This is still broken on mozilla-central, can we get this fixed for 2.0?

Comment 8

[Axel Hecht [:Pike]]

That'd be a ping for kaie, though it'd help to have a patch that's against mozilla-central instead of 1.9.1.

Comment 9

[(no longer active)]

Comment on attachment 372316 [details] [diff] [review]
Patch for 1.9.1

Maybe Johnath can review this?

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for m-c

Comment 11

[Guillermo López :willyaranda (probably SLOW response)]

Review to Johnath, because Ehsah said that!

Comment 12

[Johnathan Nightingale [:johnath]]

Comment on attachment 472722 [details] [diff] [review]
Patch for m-c

Looks fine but I haven't tested it, so this shouldn't land without someone confirming that the entities all look fine.

Honestly, I think this could have gone in with Axel's okay - there's no change of semantic, here. Anyhow - if it works, it wfm.

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 472722 [details] [diff] [review]
Patch for m-c

Requesting approval for 2.0.

It does have string impact, but only small and it eases life for a significant part of our community that work on toolchains that do magic for accesskeys.

Comment 14

[Benjamin Smedberg]

Comment on attachment 472722 [details] [diff] [review]
Patch for m-c

Gavin says he'll land this before b7. Not approved after b7.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/fbf93302de79