488078 - Don't require people to manually setting up a settings init for a new setting

Status: RESOLVED FIXED

(Skywriter Graveyard :: General, defect, P4)

Description

[Dion Almaer]

For silly reasons, if you implemented a new setting you would run into a common issue:

"hmm when I run 'set foo bar' it works fine, but if I reload the page, the fact that it is 'bar' doesn't seem to kick in"

To fix this, you had to actually manually hook into settings:init and do a reset:

  bespin.publish("settings:set:theme", {
    value: settings.get("theme")
  });

This is silly and keeps causing bugs. So, I finally fixed this and now as soon as you implement a specific hook for your own set, init will fire this off for you.

Comment 1

[Dion Almaer]

Fixed in changeset: b46a311ed352

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: General.

This bug likely still needs to be triaged and categorized.