488080 - Workers: Don't compile script if the worker is already canceled.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

We can avoid a little work here. Small perf improvement on bug 487465.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 372368 [details] [diff] [review]
Patch

r+sr=jst

As a side note, should the methods in this class be un-inlined? A bunch are virtual, some are fairly substantial etc.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

Actually, that patch breaks the test_closeOnGC test. This is better.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed changeset f2a2bb94bf9a to mozilla-central.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 394122 [details] [diff] [review]
Patch, v2

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 394122 [details] [diff] [review]
Patch, v2

I'd like to put this on the branch. It fixes an easy to reproduce slowdown that can make shutdown take way longer than necessary, and it's been tested on trunk for quite a while now.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 394122 [details] [diff] [review]
Patch, v2

a1922=beltzner

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a0e3eac94abf