488081 - Workers: Don't compile and run script if it is suspended

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Currently we compile the worker script and trigger the op callback in order to suspend a worker that should already be suspended. This is wasteful (computation time, memory, and a blocked thread) and we should simply stick the worker in a suspended queue somewhere for later.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This queues suspended worker runnables rather than executing and suspending them.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

jst, review ping!

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 394124 [details] [diff] [review]
Patch, v1

r+sr=jst

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/47741d605708

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 394124 [details] [diff] [review]
Patch, v1

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 394124 [details] [diff] [review]
Patch, v1

I'd like to get this on the branch. It prevents us from running worker code after we've already left the page it was on which can slow everything down significantly with some test cases. Also, it's baked for quite a while now.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 394124 [details] [diff] [review]
Patch, v1

a1922=beltzner

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4fcf32152c91