488083 - video scrubber thumb can overlap play/pause button and duration

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Justin Dolske [:Dolske]]

We noticed late in the UI design of bug 475318 that when the scrubber thumb is at the extreme left/right, the overhanging parts may overlap the play/pause button and duration label by a few pixels.

Decided to land the current design, and tweak things in a followup (this bug). Boriss should have an updated design.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Screengrab

Comment 3

[Justin Dolske [:Dolske]]

Also gave this a spin on Windows and Linux to verify that things are positioned the same.

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 374161 [details] [diff] [review]
Patch v.1

Not really a fan of the fixed sizes and showhours, but this is fine for now given the constraints.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 374161 [details] [diff] [review]
Patch v.1

a191=beltzner

Comment 6

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/4fbaf81986a2

Comment 7

[Justin Dolske [:Dolske]]

Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1fc6405ffaf2

Comment 8

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre 
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre)
Gecko/20090507 Shiretoko/3.5b5pre