Closed
Bug 488146
Opened 16 years ago
Closed 16 years ago
AsyncExecuteStatements does not release lock in common case when it needs to
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
VERIFIED
INVALID
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: zpao)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
Details | Diff | Splinter Review |
In Run, we need to release the lock before calling NotifyComplete. We have an invariant about not holding the lock when calling that function (but no way to assert it's true, sadly).
|
Reporter | |
Comment 1•16 years ago
|
||
Hey, even better - NotifyResults has the same issue, so it needs to be released before we call that!
|
Assignee | |
Comment 2•16 years ago
|
||
Assignee: sdwilsh → paul
Attachment #372421 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Turns out Mr. Wilsher missed something and this is actually invalid.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
|
|
Reporter | |
Comment 4•16 years ago
|
||
Yeah, there are scope brackets around the mutex holding that I somehow missed. I am blind.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Updated•16 years ago
|
Attachment #372421 -
Flags: review?(sdwilsh)
|
||
Updated•20 days ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•