Closed Bug 488265 Opened 11 years ago Closed 11 years ago

xpcPropertyBagEnumerator is unnecessary

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Basically it's a home-brewed array enumerator, which we already have in XPCOM.
Attached patch Proposed patchSplinter Review
* Removed forward from xpcforwards.h where nobody was using it
* Removed declaration from xpcprivate.h
* Converted sole consumer into using a local nsCOMArray
* Had to add an early return to avoid goto past the constructor
* Removed definition of xpcPropertyBagEnumerator
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #372591 - Flags: review?(mrbkap)
Attachment #372591 - Flags: superreview+
Attachment #372591 - Flags: review?(mrbkap)
Attachment #372591 - Flags: review+
Pushed changeset 3e3a7373a3d0 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.