Closed Bug 488329 Opened 11 years ago Closed 11 years ago

Update shipped-locales and l10n-changesets for Firefox 3.5 Beta 4


(Firefox :: General, defect, P1)

3.5 Branch



Firefox 3.5b4


(Reporter: Pike, Assigned: Pike)


(Keywords: fixed1.9.1, verified1.9.1, Whiteboard: [build requirement, tbd last minute-ish])


(3 files, 4 obsolete files)

We need to update shipped-locales and l10n-changesets prior to Firefox 3.5 Beta 4.

I'll come up with patches to land mostly land-thing in Beta 4.
Flags: blocking-firefox3.5?
Priority: -- → P1
Target Milestone: --- → Firefox 3.5b4
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Whiteboard: [build requirement, tbd last minute-ish]
Attached file l10n-changesets, wed night (obsolete) —
I don't think we need to finalize l10n-changesets and shipped-locales just yet, looking at the rest of the tree, but I'll add the current state here just in case as my day is coming to an end.
Comment on attachment 372997 [details]
l10n-changesets, wed night

New changesets are coming up later to include the bustage fixes for the privacy pane and clear history dialog.
Attachment #372997 - Attachment is obsolete: true
Attached file l10n-changesets, thu night (obsolete) —
No changes to shipped-locales, gladly, this is the current status quo of l10n-changesets for tonight.
Comment on attachment 373235 [details]
l10n-changesets, thu night

New list coming up, at least 'it' needs to rev.
Attachment #373235 - Attachment is obsolete: true
Comment on attachment 373380 [details]
state of the onion, l10n-changesets on fri night

Newer revision coming.
Attachment #373380 - Attachment is obsolete: true
Attachment #373380 - Attachment mime type: application/octet-stream → text/plain
Attached file ... tuesday, l10n-changesets (obsolete) —
... coming.
shipped-locales is stable now, we should land that on 1.9.1 already.
Attachment #373880 - Flags: approval1.9.1?
Comment on attachment 373880 [details] [diff] [review]
the diff for shipped-locales [checked in]

Attachment #373880 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 373880 [details] [diff] [review]
the diff for shipped-locales [checked in]

shipped-locales landed,
Attachment #373880 - Attachment description: the diff for shipped-locales → the diff for shipped-locales [checked in]
... and yes, I'm working on making l10n-changesets something that build can just pull instead of entertaining folks with a daily attachment.
Attachment #373867 - Attachment is obsolete: true
Has this hit 1.9.1 yet?
shipped-locales lives in the mozilla-1.9.1 repo, and has landed. l10n-changesets lives in the build/buildbot-configs repo, and hasn't landed yet AFAICT.

I'm hoping that the release engineer in charge can pick up the l10n-changesets we have just before the builds get kicked off and land that.
Can you email release-drivers with the info from comment 15? I've also cc'd Nick and Ben directly as it would affect them.
I would very much prefer that l10n-drivers explicitly bless the final l10n-changesets, rather than have RelEng assume the latest copy on the bug is up to date. The automation doesn't make it easy to one-off build any locale that turns out to be the wrong changeset.
Any version that I attached to this bug was, at the time, the best fit and good for release.

I'm not freezing on an l10n-changesets, as that would limit our ability to take improvements for locales to B4 without any pressing need to do so. Our code-side is just not stable enough for me to sign off on that at some point in time. I update to the best of my knowledge at the time, and as long as there is a non-obsolete attachment in the bug, that's what should get used.

Bottom line, as soon as the code is ready to go, please take the status quo in this bug and land it to be included in the release.
Attachment #374051 - Attachment description: rev romanian still → [checked in] rev romanian still
Comment on attachment 374051 [details]
[checked in] rev romanian still

committed changeset 1108:e0fc9f64a4ce
Resolved fixed or no?
Thomas, please don't mess with CC lists.
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.