488349 - Remove Hacks to get WinCE Tinderbox Green

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: v1.0 of mobile-borowser patch

On Friday evening, 10-April-09, the wince tinderboxes were burning because of a mismatch between what the buildbots were seeking and what the build was producing.

This was caused by an understanding of what the build would do with the check in of bug 476733, that was not carried through to the buildbots.

Because no one wanted to modify the buildbots over a weekend, a hack was put into place to make the tinderboxes go green.

This bug removes the nasty patch, and fixes up both the mobile-browser repository "make package" and "make installer" commands, as well as the buildbot expectations.

This bug is a follow-on to bug 476733.

The mobile-browser patch reverts the "make package" command to doing a "make package" build within the /objdir/mobile/mobile/installer directory.

The mobile-browser patch also removes the ZIP file production from within the mobile/installer/makefile.in file.


The buildbots will now need to do two commands for wince builds:

(1) a "make package" command at /objdir/mobile, and 

(2) a "make installer" command at /objdir/mobile 


These two command swill produce three files:

(A) a xulrunner ZIP file located at /objdir/xulrunner/dist, 

(B)a fennec ZIP (which does NOT contain a xulrunner subdirectory) at /objdir/mobile/dist, and 

(C) a fennec CAB (which does install a xulrunner subdirectory on-device) at /objdir/mobile/dist.

Comment 1

[Aki Sasaki (not active)]

Attachment: [checked in] run make package before make installer for wince

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 372718 [details] [diff] [review]
[checked in] run make package before make installer for wince

You can probably just drop the descriptions if you want, since they're the same as the command...up to you though.
r=bhearsum either way.

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 372718 [details] [diff] [review]
[checked in] run make package before make installer for wince

Looks like this rode along with rev 261:9f3e6517d946

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #3)
> (From update of attachment 372718 [details] [diff] [review])
> Looks like this rode along with rev 261:9f3e6517d946

so can this be closed out?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

hearing no objections for 5 months, I'm closing this out

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

marking as verified.