48838 - Context menus need to first set focus to the widget you right-click on

Status: VERIFIED FIXED

(Core :: XUL, defect, P4)

Description

[Blake Ross]

Standard behavior on windows is that when you right click on a widget, focus is 
first set to that widget, and then the items on the context menu that appears 
all affect that widget.  The current menu system is flawed, and doesn't work 
this way.  Instead, if an element has the focus and you click elsewhere, the 
context menu that appears still has items that affect the element that has the 
focus.  This is incorrect, and has repercussions in many areas of the product: 
selection and editor to name a few.

Try this: go to a website with a textbox, type a few characters into the 
textbox, set focus to the URL bar, then right click on the textbox in the 
site.  Then click Select All in the context menu that appears.  Note that while 
Select All actually selects the contents of the URL bar, other items on the 
same context menu (like Bookmark this Page and Save Page As...) actually apply 
to the website itself.

There are other examples like this throughout the product, and I'm willing to 
give more if need be.  I don't think this is a quick FUTURE because it's a 
serious flaw in our event handling (er, should this be under event handling?) 
and is inconsistent with Windows behavior (and possible that of other 
platforms...)

Comment 1

[Matthew T (active 1999-2002)]

Nominating for beta 3. This is bad.

Comment 2

[Blake Ross]

reassigning to saari, who agreed to take a look. says context clicks just need 
to fire a focus event first, which should be easy...

Comment 3

[Peter Trudelle]

nsbeta3+ to take (partial) in-hand fix. p4 for M18

Comment 4

[saari (gone)]

*** Bug 40796 has been marked as a duplicate of this bug. ***

Comment 5

[Peter Trudelle]

Please note that we are not committing to fix P4/P5 bugs for N6, although we 
could still work on a fix in priority order, or take a patch.

Comment 6

[saari (gone)]

Fixed

Comment 7

[saari (gone)]

marking fixed :-P

Comment 8

[shrirang khanzode]

verified on windows build 2000091208m18,