Closed
Bug 488426
Opened 17 years ago
Closed 16 years ago
enable TIS-620 detector
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(2 files, 1 obsolete file)
|
5.80 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
|
714 bytes,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
extensions/universalchardet/src/base/LangThaiModel.cpp seems to be excluded building source file on Windows. I don't know why, but I found a missing line in nsSBCharSetProber.h.
The patch makes building fine on Windows XP.
|
Assignee | |
Comment 1•17 years ago
|
||
Comment on attachment 372803 [details] [diff] [review]
A patch
Simon, could you please take a look into this?
Attachment #372803 -
Flags: review?(smontagu)
|
||
Comment 2•17 years ago
|
||
Looks reasonable, but there still won't be any autodetection of Thai unless you add a prober in nsSBCSGroupProber::nsSBCSGroupProber.
|
|
Assignee | |
Comment 3•17 years ago
|
||
I did not notice nsSBCSGroupProber::nsSBCSGroupProber.
The patch includes test case for TIS-620 detector. TIS-620 string in test case was copied from http://en.wikipedia.org/wiki/TIS-620 and convert it with iconv.
Attachment #372803 -
Attachment is obsolete: true
Attachment #374205 -
Flags: review?(smontagu)
Attachment #372803 -
Flags: review?(smontagu)
|
|
Assignee | |
Updated•17 years ago
|
Summary: build LangThaiModel.cpp on Windows → enable TIS-620 detector
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 374205 [details] [diff] [review]
Revised patch with test
Don't you need both patches? Why did you obsolete the previous one?
Attachment #374205 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Oops! I forgot to include diff of Makefile.in.
|
|
||
Updated•17 years ago
|
Attachment #377127 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•16 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•