488426 - enable TIS-620 detector

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: A patch

extensions/universalchardet/src/base/LangThaiModel.cpp seems to be excluded building source file on Windows. I don't know why, but I found a missing line in nsSBCharSetProber.h.

The patch makes building fine on Windows XP.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 372803 [details] [diff] [review]
A patch

Simon, could you please take a look into this?

Comment 2

[Simon Montagu :smontagu]

Looks reasonable, but there still won't be any autodetection of Thai unless you add a prober in nsSBCSGroupProber::nsSBCSGroupProber.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Revised patch with test

I did not notice nsSBCSGroupProber::nsSBCSGroupProber.

The patch includes test case for TIS-620 detector. TIS-620 string in test case was copied from http://en.wikipedia.org/wiki/TIS-620 and convert it with iconv.

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 374205 [details] [diff] [review]
Revised patch with test

Don't you need both patches? Why did you obsolete the previous one?

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Makefile.in fix

Oops! I forgot to include diff of Makefile.in.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Pushed.

http://hg.mozilla.org/mozilla-central/rev/a3a6183d5a22