Closed Bug 488478 Opened 15 years ago Closed 15 years ago

Mac pyspy work on mac to trigger mem dump.

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: treilly, Assigned: rishah)

Details

Attachments

(1 file, 3 obsolete files)

[v3] patch
17.31 KB, patch
treilly
: review+
Details | Diff | Splinter Review 
signal's and a unix domain socket should suffice.
Attached patch [v1] patch (obsolete) — — Splinter Review 

        Attachment #373003 -
        Flags: review?(treilly)

    
    

    
  
Note: Will remove the print statements from pyspy-mac.  They were added for debugging aid.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        [v1.1] patch (obsolete)
        — 
          — Splinter Review
      

    


  
New patch with minor cleanup.

        Attachment #373003 -
        Attachment is obsolete: true

        Attachment #373005 -
        Flags: review?(treilly)

        Attachment #373003 -
        Flags: review?(treilly)

    
    

    
  
Comment on attachment 373003 [details] [diff] [review]
[v1] patch

Awesome, lets merge pyspy-mac w/ the other pyspy and do platform detection in the script.

What's with the s.send('Hello')?

This impl looks more posix than mac, wanna be optimistic and use the same code for linux/solaris too?

        Attachment #373003 -
        Flags: review-

    
    

    
  
> What's with the s.send('Hello')?
It is a message to break from select() on the server side.  I could select() on the write descriptor i guess.  Will change it.

 
> This impl looks more posix than mac, wanna be optimistic and use the same code
> for linux/solaris too?
Yes the idea was to have the same code use for all posix platforms.  I kept the name mac for now and would move it to pyspy-posix/SpyUtilsPosix as the next step since SpyutilsMac.cpp was already added.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        [v2] patch (obsolete)
        — 
          — Splinter Review
      

    


  
Incorporating feedback from v1 patch review -

- Combining pyspy for mac and win
- renaming spyutilsmac.cpp to spyutilsposix.cpp
- removing s.send('Hello') from pyspy code for posix/mac.  instead select now waits for write descriptor on socket to be ready

        Attachment #373005 -
        Attachment is obsolete: true

        Attachment #373061 -
        Flags: review?(treilly)

        Attachment #373005 -
        Flags: review?(treilly)

    
  

        Attachment #373061 -
        Attachment is patch: true

        Attachment #373061 -
        Attachment mime type: application/octet-stream → text/plain

    
  

        Attachment #373061 -
        Flags: review?(treilly) → review-

    
    

    
  
Comment on attachment 373061 [details] [diff] [review]
[v2] patch

check out sys.platform I think that will allow to get rid of the platform argument.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        [v3] patch
        — 
          — Splinter Review
      

    


  
platform detection changes in pyspy

        Attachment #373061 -
        Attachment is obsolete: true

        Attachment #373151 -
        Flags: review?(treilly)

    
  

        Attachment #373151 -
        Flags: review?(treilly) → review+

    
    

    
  
changeset 1762	b38308650a08
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: