48859 - the columns in the xpinstall & xpstatus dialogs aren't resizeable

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P1)

Description

[Stephen Walker]

The module name & location columns in the xpinstall & xpstatus dialogs aren't 
resizeable

Comment 1

[Jimmy Lee]

Ccing Dan and David.

Comment 2

[Brendan Eich [:brendan]]

Attachment: blake's patch

Comment 3

[Brendan Eich [:brendan]]

a=[e-mail] -- blake, please attach patches to bugs rather than 
mailing them to me.  Thanks,

/be

Comment 4

[Blake Ross]

Sorry.  Maybe the tinderbox rules should be updated, then... "submit patches to 
[e-mail]"

Comment 5

[Daniel Veditz [:dveditz]]

CCing Don, he was going to do similar stuff, maybe now he doesn't have to. Don 
should still make the dlg as a whole resizable, which this bug/patch doesn't 
address.

Comment 6

[Blake Ross]

I can do that.  file a separate bug against me.

Comment 7

[dbragg]

Actually all you (or I) need to add is the "resizeable" keyword to the chrome 
list in the JS_PushArguments call.  I've already got "chrome,titlebar" .  Just 
need to make it "chrome,titlebar,resizeable".  I was going to do that with the 
fix for the "parent" bug but you can do it if you want Blake.

Comment 8

[Blake Ross]

That's all I as going to do ;) But you can go ahead, I guess.

fix checked in..

Comment 9

[Jimmy Lee]

Build: 2000-09-13-09-M18(WIN), 2000-09-13-04-M18(MAC), 2000-09-13-08-M18(LINUX)

They were not resizeable in yesterday's builds nor are they today.  We can 
really use this fix, too.  Marking Reopened.

Comment 10

[Blake Ross]

huh? really? works for me fine in 2000091308 win98...

Comment 11

[Blake Ross]

Note that the visible separators don't appear between the two columns (a 
separate bug), but you can still resize them...

Comment 12

[Jimmy Lee]

Build: 2000-09-13-09-M18(WIN), 2000-09-13-04-M18(MAC), 2000-09-13-08-M18(LINUX)

Alright.  It does work.  As you can see, it was not visually clear to me that I 
could resize the columns.  I'm going to write a new bug regarding this matter.  
However, this one is fixed.  Mark this one fixed, and I'll mark it Verified.

Thanks for the clarification.

Comment 13

[Blake Ross]

re-marking fixed.  did you ever get around to filing that other bug, dbragg?

Comment 14

[Jimmy Lee]

Remarking Verified.  Bug 52512 refers to adding some visual indicator that 
columns are resizable.  Thanks.