Closed Bug 488590 Opened 15 years ago Closed 15 years ago

gloda throws this.indexer undefined exception on folder deleted notification

Categories

(MailNews Core :: Database, defect)

Product:
MailNews Core
Component:
Database
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b3

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file, 1 obsolete file)

proposed fix
1.93 KB, patch
asuth
: review+
standard8
: superreview+
Details | Diff | Splinter Review
Attached patch proposed fix (obsolete) — — Splinter Review 
I ran into this switching the folder pane over to the folder notification service, and I'd like to fix it so that I don't see any exceptions in my tests.

The attached patch fixes it - there are a lot of ways to fix this, I guess, but this is a simple way.
Attachment #372996 - Flags: superreview?(bugzilla)
Attachment #372996 - Flags: review?(bugmail)
I agree that we should have a test case for this, and all the other notifications, to make sure we're doing the right thing with each notification.
Flags: in-testsuite?
Comment on attachment 372996 [details] [diff] [review]
proposed fix

hmm, this seems to be throwing an exception on load...
Attachment #372996 - Flags: superreview?(bugzilla)
Attachment #372996 - Flags: review?(bugmail)
Attached patch proposed fix — — Splinter Review 
duh, gloda was calling a non-existent function, which was "throwing" me for a loop.
Attachment #372996 - Attachment is obsolete: true
Attachment #373007 - Flags: superreview?(bugzilla)
Attachment #373007 - Flags: review?(bugmail)
Attachment #373007 - Flags: superreview?(bugzilla) → superreview+
Comment on attachment 373007 [details] [diff] [review]
proposed fix

it would've worked in python!
Attachment #373007 - Flags: review?(bugmail) → review+
fix checked in
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
Does gloda have a test for this? If so, I can mark it in-testsuite+
No, not yet.  This is one of the things I was saying I was somewhat concerned about since it's not entirely locked down.  I'll try and finish fleshing out the unit tests for gloda over the next few days... it's so close to super reliable that it would be a shame to leave holes in coverage.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: