488768 - Pork: Reorganize directory structure

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It would be frabulous to run

 $ hg clone http://hg.mozilla.org/pork

and get the directory structure

  pork/
    # current piglet/ stuff
    piglet.h
    patcher.h
    ...

    # current pork-barrel/ stuff
    pork-barrel.cc
    pork_barrel.py
    process_manager.py

    porkyc
    porky/

    # pork tools currently in oink/
    tools/
      renamer.cc
      outparamdel.cc
      ...

    elsa/
    elkhound/
    ...

If the likelihood of getting upstream patches for elsa and friends is high enough, I would be OK with checking them separately.  However, I would like them conform to the directory structure above.

With all this in place, having a single |./configure| from within the pork/ directory is very easy.

Better ideas?

Comment 1

[(dormant account)]

Attachment: Support for new elsa structure

hey Chris,
sorry for the long wait. Hope this fits the bill.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 379791 [details] [diff] [review]
Support for new elsa structure

Elsa build/configure stuff looks fine to me.

>diff --git a/stopwatch.cc b/stopwatch.cc
>--- a/stopwatch.cc
>+++ b/stopwatch.cc
...
>@@ -84,17 +82,18 @@ private:
> int main(int argc, char **argv)
> {
>   xassert(argc >= 2);
>-  const char *filename = argv[1];
>-  string line;
>+  int current_arg = 1;
>+  /*const char *filename = argv[current_arg++];
>+    string line;
>   ifstream f(filename);
>   while (getline(f, line)) {
>     methods.insert(line.c_str());
>   }
>-  f.close();
>+  f.close();*/

Many would probably call this out as a nit.  But it's irrelevant to the pork reorg.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to comment #1)
> Created an attachment (id=379791) [details]
> Support for new elsa structure
> 
> hey Chris,
> sorry for the long wait. Hope this fits the bill.

So far, so good.  I assume there's more to come?

Comment 4

[(dormant account)]

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=379791) [details] [details]
> > Support for new elsa structure
> > 
> > hey Chris,
> > sorry for the long wait. Hope this fits the bill.
> 
> So far, so good.  I assume there's more to come?

That's as far as my needs led me. How much more do you need?

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > > Created an attachment (id=379791) [details] [details] [details]
> > > Support for new elsa structure
> > > 
> > > hey Chris,
> > > sorry for the long wait. Hope this fits the bill.
> > 
> > So far, so good.  I assume there's more to come?
> 
> That's as far as my needs led me. How much more do you need?

Need/want is a sticky wicket.  I think if we follow all the way through, pork could be easier to set up and understand.

From what I proposed in comment #0, this remains:

(1) Create an http://hg.mozilla.org/pork repo.
(2) Move our tools (outparamdel et al.) that currently live in oink/ into pork/tools/.  They shouldn't (don't? maybe?) depend on oink/.
(3) The pork-barrel repo should go away, and all its files should be moved into the root of pork/.
(4) Your tglek/piglet repo should go away, and all its files should be moved into the root of pork/.

For politeness to hg.mozilla.org, all the repos that are now (or should be) subdirectories of elsa/ should be removed.  The oink* repos should also be nuked.

From chatting with you on IRC, I think some of this at least is on your agenda.  Just wanted to be specific.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

> (4) Your tglek/piglet repo should go away, and all its files should be moved
> into the root of pork/.
> 

Oh, and if this happens, then s/piglet.*/pork.*/, as these two files nicely encapsulate the engine room of the toolchain.  But I don't care so much about names atm.

Comment 7

[(dormant account)]

pushed http://hg.mozilla.org/users/tglek_mozilla.com/piglet/rev/7be27766257f

I was mainly asking about any further drastic changes, good to hear that you just want the administrative things. I'll get to that once the the dust settles on the current stuff(and you push porky into piglet).