Closed
Bug 488770
Opened 16 years ago
Closed 16 years ago
ShellCommand subclasses must make sure description and descriptionDone are lists, not strings
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Unassigned)
Details
Attachments
(1 file)
1011 bytes,
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
While testing bug 487496 on Buildbot 0.7.9 I hit a traceback on the waterfall that was rooted in CompareLeakLogs and CompareBloatLogs using strings for self.description and self.descriptionDone. A bunch of Buildbot web code assumes that it is a list. Interestingly, I didn't hit this when running the same code on 0.7.10p1. In any case, we should fix it.
Attachment #373218 -
Flags: review?(catlee)
Updated•16 years ago
|
Attachment #373218 -
Flags: review?(catlee) → review+
Reporter | ||
Comment 1•16 years ago
|
||
Comment on attachment 373218 [details] [diff] [review]
use lists for descriptions
changeset: 252:3102eb8e1ed6
Attachment #373218 -
Flags: checked‑in+
Reporter | ||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> (From update of attachment 373218 [details] [diff] [review])
> changeset: 252:3102eb8e1ed6
I reconfig'ed production-master and try-master for this.
Reporter | ||
Comment 3•16 years ago
|
||
No problems with this, resolving.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•