488786 - nsDocument::mPendingTitleChangeEvent keeps the document alive longer than needed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Because nsDocument::mPendingTitleChangeEvent contains an event that owns the document, it can keep documents alive longer than needed.  This confuses real-time leak detection tools such as DEBUG_CC and leak-monitor.

In this case, there's no need for the event to own the document, since the document can revoke the event in its own destructor.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/611a06f94bb6

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 373245 [details] [diff] [review]
patch

This is a relatively simple fix that makes leak-monitor a good bit less noisy.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373245 [details] [diff] [review]
patch

a191=beltzner

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4610c0a8f3cc