488821 - rememberChoice checkboxes conflict in two tabs with geolocation notifications

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

When two tabs both display a geolocation notification, each one has a checkbox element with id="rememberChoice", and one of the tabs will retrieve the other's checkbox when it does |notification.ownerDocument.getElementById("rememberChoice")|, which means that the other tab's checkbox will determine whether or not the pref is saved.

One fix would be to make the checkbox's identifier a class rather than an ID and then retrieve the checkbox relative to its containing notification in the callbacks, f.e. via |notification.getElementsByClassName("rememberChoice")[0]|.

Another would be to make its identifier an |anonid| attribute and then use getAnonymousElementByAttribute or getElementsByAttribute to retrieve it relative to its containing notification.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: uses class instead

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 373289 [details] [diff] [review]
patch v1: uses class instead

this looks fine to me, lets let gavin look too.

Comment 3

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/ab9bed26019e

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373289 [details] [diff] [review]
patch v1: uses class instead

a191=beltzner

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/136fd0e05bfb