Closed Bug 488838 Opened 12 years ago Closed 12 years ago
make -j9 build of Mail
News tests fails
Building with tests enabled fails when using -j9 option for make: /usr/lib64/gcc/x86_64-suse-linux/4.3/../../../../x86_64-suse-linux/bin/ld: cannot find -lmsgbaseutil collect2: ld returned 1 exit status gmake: *** [TestMsgStripRE] Error 1 gmake: Leaving directory `/home/i6stud/sibresch/seamonkey_hg/objdir/mailnews/base/test' gmake: *** [test_libs] Error 2
Attachment #373305 - Flags: superreview?(bienvenu) → superreview+
Attachment #373305 - Flags: review?(gozer) → review-
Comment on attachment 373305 [details] [diff] [review] move test from PARALLEL_DIRS to DIRS >diff --git a/mailnews/base/Makefile.in b/mailnews/base/Makefile.in >--- a/mailnews/base/Makefile.in >+++ b/mailnews/base/Makefile.in > [...] >+DIRS = search/public >+ > ifdef ENABLE_TESTS >-PARALLEL_DIRS += test >+DIRS += test > endif > >-DIRS = search/public >- > include $(topsrcdir)/config/rules.mk Why also move DIRS around, looks unrelated. Wouldn't leaving DIRS = search/public where it is and just make it DIRS += search/public be good enough ? Otherwise, having the test target in PARALLEL_DIRS does sound incorrect.
Don't you have to declare DIRS before you can use += on it? In that case DIRS += search/public would only work, if we have tests enabled.
Comment on attachment 373305 [details] [diff] [review] move test from PARALLEL_DIRS to DIRS With comment #2, I am changing my previous comment. Looks good.
Attachment #373305 - Flags: review- → review+
(In reply to comment #2) > Don't you have to declare DIRS before you can use += on it? Based on what I (successfully) tried in bug 488091, it would seem += can be used directly... Then you can choose/confirm which way you want to fix this bug. (Of course, there's nothing wrong with the current patch.)
(In reply to comment #4) > Then you can choose/confirm which way you want to fix this bug. > (Of course, there's nothing wrong with the current patch.) FTR this was decided on irc which is why gozer changed from - to +. Checked in: http://hg.mozilla.org/comm-central/rev/557a2e8aab95
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.