489034 - let declaration getting lost in certain situations

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Dão Gottwald [:dao]]

Attachment: tests

See attached tests. Those with nested setTimeouts or a setTimeout in an event listener fail on branch but pass on 1.9 *and on trunk*. I'm filing this bug, because I don't know:

* what fixed this on trunk
* if that other bug was exactly about this issue
* in case it was about a different issue, if that is already blocking
* and if similar tests are in the testsuite now.

Comment 1

[Brendan Eich [:brendan]]

Bug 488015?

/be

Comment 2

[Robert Sayre]

just landed Bug 488015 on branch

Comment 3

[Dão Gottwald [:dao]]

Works on 1.9.1 with the latest hourly.

Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9.1b4pre) Gecko/20090418 Shiretoko/3.5b4pre

Comment 4

[Dão Gottwald [:dao]]

This is broken again on trunk, not yet on branch.

Comment 5

[Brendan Eich [:brendan]]

Attachment: shell testcase

Comment 6

[Brendan Eich [:brendan]]

Removing fixed1.9.1 to be safe.

/be

Comment 7

[Brendan Eich [:brendan]]

Attachment: top-level let is special, sigh

Every function in between a non-heavyweight closure we can't optimize into a flat or null closure must be heavyweight, if there's a top level let binding used by the innermost function being considered. This fixes Dao's test (thanks for that test, btw!).

/be

Comment 8

[Brendan Eich [:brendan]]

Fixed in tm:

http://hg.mozilla.org/tracemonkey/rev/f9f05f6e7faa

/be

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/f9f05f6e7faa

Comment 10

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/da87c406cfe4