489168 - Leaking nsAbCardProperty when collecting addresses for email addresses that already exist in the address book

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I was just testing some xpcshell patches, in particular taking a brief look at the ones that will tidy up the leak/bloat of xpcshell tests and discovered a leak in the address collector.

When we collect an email address and that email address already exists in the database, we're getting a result from nsAbAddressCollector::GetCardFromProperty. The issue is that function returns a simple nsIAbCard* which is the result from GetCardForEmailAddress - which has already been addrefed, but not taken into account here. Therefore we should wrap the result type in already_AddRefed which will then mean we don't leak the nsAbCardProperty.

Comment 1

[[e-mail]]

Comment on attachment 373654 [details] [diff] [review]
The fix

Bah, I didn't spot that :-(

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/b8c8bf5edbf2