Closed Bug 489168 Opened 12 years ago Closed 12 years ago
Ab Card Property when collecting addresses for email addresses that already exist in the address book
I was just testing some xpcshell patches, in particular taking a brief look at the ones that will tidy up the leak/bloat of xpcshell tests and discovered a leak in the address collector. When we collect an email address and that email address already exists in the database, we're getting a result from nsAbAddressCollector::GetCardFromProperty. The issue is that function returns a simple nsIAbCard* which is the result from GetCardForEmailAddress - which has already been addrefed, but not taken into account here. Therefore we should wrap the result type in already_AddRefed which will then mean we don't leak the nsAbCardProperty.
Comment on attachment 373654 [details] [diff] [review] The fix Bah, I didn't spot that :-(
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.