489224 - Printing doesn't print text field values

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

<input type="text"> and <textarea> are printed as empty, even if they
contained some text.

I guess this might be a regression from my printing changes.
Will verify tomorrow.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Oh, I haven't tested this on 1.9.1 yet.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes, also in 1.9.1

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

And should be pretty easy to fix. Will write the patch tomorrow.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same happens with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090420 Shiretoko/3.5b4pre ID:20090420031111

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: for trunk

The interesting part is the last hunk in the patch.
I want to be very strict when to allow mutations.
Most of the patch is just moving nsDocumentObserverForNonDynamicPresContext,
so that it can use PresShell.

(Form elements will need some special handling also with clone-document-for-printing approach I'm doing for trunk.)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

1.9.1 will need just a bit different patch, and I'll write tests before landing.
(well, if this gets review)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: for 1.9.1

The only difference is the last hunk in the patch.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 373887 [details] [diff] [review]
for trunk

This is yucky. Can't wait for document cloning!

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: print preview tests for each form element (with and without content)

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/44d20da17412

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f062a51f5446

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on trunk and 1.9.1 with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090423 Minefield/3.6a1pre ID:20090423040020

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre ID:20090423040926