489225 - Cleanup CanvasBrowser.js

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ben Combee (:bcombee)]

Attachment: Cleanup CanvasBrowser

While working on the panning indicator patch, I noticed lots of places where CanvasBrowser needs to be brought up to current specs.  This is a cleanup patch that doesn't add/remove any functionality.  It just does

1) add names to function definitions for better stack traces

2) move member initialization into the constructor for CanvasBrowser instead of having them as members of the prototype object.  This is the correct way to set these up -- having data members in prototype is only useful for data shared by all CanvasBrowser instances.

3) add more comments describing how CanvasBrowser members are used

My indicators patch will rely on this being committed, so I've marked it as blocking that below.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 373730 [details] [diff] [review]
Cleanup CanvasBrowser

We might want to add scope prefixes to function names, but this is better than no function names.

Comment 2

[Ben Combee (:bcombee)]

Attachment: Update for bitrot after toolbar fix

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/99a30b5c1e57

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on code inspection