489239 - comm-central windows builds broken by unit test for bug 58904

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mark Banner (:standard8)]

I haven't been able to figure this out yet, since bug 58904 landed Thunderbird's trunk unit test tinderbox has been failing to build and a clobber doesn't help, the error is:

link -nologo -out:TestSynchronization.exe -pdb:TestSynchronization.pdb TestSynchronization.obj  -NXCOMPAT -SAFESEH -DYNAMICBASE  -MANIFEST:NO -LIBPATH:"e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/memory/jemalloc/crtsrc/build/intel" -NODEFAULTLIB:msvcrt -NODEFAULTLIB:msvcrtd -DEFAULTLIB:mozcrt19   e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/xpcom.lib e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/xpcom_core.lib e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/xpcomglue_s.lib e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/xpcom.lib e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/nspr4.lib e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/plc4.lib e:/buildbot/win32-comm-central-check/build/objdir-tb/mozilla/dist/lib/plds4.lib   kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib
TestSynchronization.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall mozilla::Mutex::~Mutex(void)" (__imp_??1Mutex@mozilla@@QAE@XZ) referenced in function __unwindfunclet$?Sanity@@YAIXZ$0
TestSynchronization.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall mozilla::Monitor::Monitor(char const *)" (__imp_??0Monitor@mozilla@@QAE@PBD@Z) referenced in function "unsigned int __cdecl Sanity(void)" (?Sanity@@YAIXZ)
TestSynchronization.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall mozilla::Mutex::Mutex(char const *)" (__imp_??0Mutex@mozilla@@QAE@PBD@Z) referenced in function "unsigned int __cdecl Sanity(void)" (?Sanity@@YAIXZ)
TestSynchronization.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall mozilla::MutexAutoLock::~MutexAutoLock(void)" (__imp_??1MutexAutoLock@mozilla@@QAE@XZ) referenced in function __unwindfunclet$?AutoLock@@YAIXZ$0
TestSynchronization.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall mozilla::Monitor::~Monitor(void)" (__imp_??1Monitor@mozilla@@QAE@XZ) referenced in function __unwindfunclet$?AutoMonitor@@YAIXZ$0
TestSynchronization.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall mozilla::CondVar::CondVar(class mozilla::Mutex &,char const *)" (__imp_??0CondVar@mozilla@@QAE@AAVMutex@1@PBD@Z) referenced in function "unsigned int __cdecl CondVarSanity(void)" (?CondVarSanity@@YAIXZ)
TestSynchronization.exe : fatal error LNK1120: 6 unresolved externals

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1240258379.1240260595.15518.gz

A couple of things to note:

- Thunderbird doesn't build libxul by default, therefore this tinderbox attempts to build TestSynchronization.exe
- The tinderbox doesn't have -j specified.

I've just done a build (from scratch) on my windows vista VM with the same settings as the tinderbox and have got the same failure, after getting that failure, doing a "make" in mozilla/xpcom/tests was successful, hence fixing the problem.

My VM build does use -j3, but the fact that our tinderbox does kinda rules parallel builds out.

I also have no idea why this only seems to manifest itself on Windows and not Linux or Mac.

Comment 1

[Benjamin Smedberg]

You probably want to add some set of stuff to dlldeps.cpp

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Thanks to Benjamin for the hint. I could probably check this in as a bustage fix, but I'd like someone to give it a quick look.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

BTW, I had literally just started writing this message when I saw your e-mail (it took me most of the evening to get the thunderbird build set up) :)

I wasn't able to reproduce this bug.  Were you doing an optimized build?  I tried debug.  (And yes, I overrode the default 1.9.1 branch with mozilla-central.)

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> BTW, I had literally just started writing this message when I saw your e-mail
> (it took me most of the evening to get the thunderbird build set up) :)
> 
> I wasn't able to reproduce this bug.  Were you doing an optimized build?  I
> tried debug.  (And yes, I overrode the default 1.9.1 branch with
> mozilla-central.)

The Thunderbird unit test builds are optimised with no debug. I'm not sure I actually tried reproducing on a debug build.

You could probably reproduce this with firefox if you did an optimised, non-libxul build.

And my previous comment about doing a make to fix it was wrong - I'd done the make in the wrong object tree.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/fba47e2a4b28 with bustage fix: http://hg.mozilla.org/mozilla-central/rev/87ba7f677dfd