Add Search Functionality to Gallery

VERIFIED FIXED in 1.6

Status

P2
normal
VERIFIED FIXED
10 years ago
6 years ago

People

(Reporter: telliott, Assigned: rdoherty)

Tracking

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
New form for search. We can't push it up to the main server, but moving into place for deployment on personas.services at some time.

Form itself needs a little love. It's lnes 81-83 in server/viewpersonas.php, but if you want to make it more complex, we can pull it out into a template easily enough.
(Reporter)

Updated

10 years ago
Target Milestone: -- → 1.1

Updated

10 years ago
Target Milestone: 1.1 → 1.2

Updated

10 years ago
Priority: -- → P2

Updated

10 years ago
Target Milestone: 1.2 → 1.3

Updated

10 years ago
Priority: P2 → P3

Updated

10 years ago
Target Milestone: 1.3 → 1.4

Updated

10 years ago
Priority: P3 → P2
(Assignee)

Comment 1

10 years ago
Styled the submit button. Not sure what else to do, there's not much to a search form :)
(In reply to comment #1)
> Styled the submit button. Not sure what else to do, there's not much to a
> search form :)

Well, if you really wanted to, you could style it like the small, yellow search form on the right of https://support.mozilla.com/tiki-login_scr.php (but thinner; basically just putting a border around the text-input field), but I'm not trying to add more work for you :-)

I do think, however, we should list the search-term criteria by which users can search -- that's a separate bug.
OS: Mac OS X → All
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> Well, if you really wanted to, you could style it like the small, yellow search
> form on the right of https://support.mozilla.com/tiki-login_scr.php (but
> thinner; basically just putting a border around the text-input field), but I'm
> not trying to add more work for you :-)

That kind of design is fine for when the search form is in a sidebar, but since this is a page, I don't think it will work.

> 
> I do think, however, we should list the search-term criteria by which users can
> search -- that's a separate bug.

Yeah, this is a good idea, can do.

Updated

10 years ago
Target Milestone: 1.4 → 1.5

Updated

10 years ago
Summary: Website: Search box needs some design love → Website: Add Search Functionality to Gallery

Updated

10 years ago
Depends on: 493979
Assignee: rdoherty → nobody
Component: Personas → getpersonas.com
Product: Mozilla Labs → Websites
QA Contact: personas → getpersonas-com
Summary: Website: Add Search Functionality to Gallery → Add Search Functionality to Gallery
Version: 0.3 → other
(Assignee)

Comment 4

10 years ago
Not sure why Reed assigned this to nobody...
Assignee: nobody → rdoherty

Updated

10 years ago
Target Milestone: 1.5 → 1.6
(Assignee)

Comment 5

10 years ago
Adding the search box above the category list.
(Assignee)

Comment 6

10 years ago
Created attachment 386147 [details]
screenshot

I found the designs for the Personas website when it still had the search box in it and I thought it looked good, so I did it that way. Screenshot attached, code is committed.
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Raymond, please test this with both JavaScript enabled/disabled, and then perhaps with IE 7, and verify it if it's all good; thanks!
http://screencast.com/t/OvElHzoU6 this is how it looks on ie 7,
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

10 years ago
Fixed, should be up on stage in ~10 mins.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
Created attachment 386395 [details]
Post-fix screenshot, IE 7

I'll let Raymond do the final honors in this one.
Component: getpersonas.com → getpersonas.com
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.