Closed Bug 489306 Opened 15 years ago Closed 15 years ago

overflowed content doesn't expose child text accessibles

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.9.1)

Attachments

(2 files)

<div style="overflow: auto">long content</div> doesn't expose child text accessible. I suspect bug 483573 because there we introduced walking through frames if there is anonymous content. I have wip patch that fixes the problem (fix logic of a11y tree walker) and will post it once I'll polish it.
Attached patch patchSplinter Review
short description: when I added querying to anonymous content creator then a11y tree walker founds scrollbar element in the case of overflowed div, scrollbar isn't accessible so it checks it first child , GetFirstChild is called again and then GetKids. GetKids sees it's XUL element so it nulls frame of current state before we put the current state on stack.
Attachment #373824 - Flags: review?(david.bolter)
Attachment #373824 - Flags: review?(marco.zehe)
Status: NEW → ASSIGNED
Comment on attachment 373824 [details] [diff] [review]
patch

>+   * DOM/frame subtree duiring searching of accessible children.

Nit: Typo "diuring" instead of "during".

>+   * Pop state from stack and makes it current.

Nit: Either "pops state...and makes..." or "pop state...and make it..." I'd prefer the latter (the one with pop and make).
Attachment #373824 - Flags: review?(marco.zehe) → review+
Comment on attachment 373824 [details] [diff] [review]
patch

r=me
Attachment #373824 - Flags: review?(david.bolter) → review+
Comment on attachment 373824 [details] [diff] [review]
patch

must be landed with bug 483573
Attachment #373824 - Flags: approval1.9.1?
checked in http://hg.mozilla.org/mozilla-central/rev/81273d925ba9
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 373824 [details] [diff] [review]
patch

a191=beltzner
Attachment #373824 - Flags: approval1.9.1? → approval1.9.1+
Attached patch patch 1.9.1Splinter Review
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090503 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Status: RESOLVED → VERIFIED
Blocks: 492516
You need to log in before you can comment on or make changes to this bug.