489389 - temporary image when doing zoomed tiling rendered too large [slow zoom scrolling]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Can't find a bug on this, but when we have a tiled image and we render when zoomed, we're creating a way too large temporary image in nsThebesImage::Draw .  We should at the very least be using the dirty rect to limit this.

For x/y repeat images we should be able to pad in just one direction and take advantage of native repeat.

Comment 1

[Rob Campbell [:rc] (:robcee)]

the test page I saw that caused this problem was http://ajaxian.com/. Scroll up a couple of levels and scrolling becomes unusable.

Comment 2

[Jason Tackaberry]

Related to bug 480806?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Passes reftests on my machine. Most of the patch is just indentation changes and comments.

Comment 4

[Joe Drew (not getting mail)]

Roc, could you also attach a whitespace-insensitive patch?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: diff -w

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 375561 [details] [diff] [review]
fix

I was close :)  Looks fine.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/26c4c46fcaac

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a724846bb344