Disable Breakpad submission for non-official builds

VERIFIED FIXED in Camino2.0

Status

VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)

Tracking

(Blocks: 1 bug)

unspecified
Camino2.0
All
Mac OS X
Dependency tree / graph
Bug Flags:
camino2.0b3 +

Details

Attachments

(1 attachment)

Once all is said and done and we're done testing, we need to disable Breakpad submission in non-official builds, since they won't be uploading symbols and they're unofficial ;)

However, we need to make sure that it's fairly easy for us to override this in order to be able to test new patches or Breakpad upgrades locally before landing.
(Assignee)

Updated

10 years ago
Assignee: nobody → stuart.morgan+bugzilla
(Assignee)

Comment 1

9 years ago
Created attachment 379375 [details] [diff] [review]
fix

This uses the same approach we use for Sparkle: we only insert the URL into the plist in an official build, and we don't enable it if the URL is empty.

This includes Ilya's fix in bug 492387 since they can't really be separated and there's no harm in landing them together.
Attachment #379375 - Flags: superreview?(mikepinkerton)
(Assignee)

Updated

9 years ago
Blocks: 493587
I'd like to block b3 on this, if for some reason it's still waiting once we have an open tree again.
Flags: camino2.0b3?
In the long run, it might be good to figure out a way to disable Breakpad submission by default on hourlies, too (that same 09 hourly has two more crashes again today); I can file a low-priority follow-up on that once this lands.
(Assignee)

Updated

9 years ago
Flags: camino2.0b3? → camino2.0b3+
Target Milestone: --- → Camino2.0
Attachment #379375 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 5

9 years ago
Landed on CVS trunk.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

9 years ago
Sigh. The patch (and thus the checkin) missed the Info-Camino.plist.in change to actually use %BREAKPAD_UPLOAD_URL% as the value.

Landed on CVS trunk, so this should actually work now.

Comment 7

9 years ago
After rebuilding with the additional checkin from comment 6, no more Breakpad reporters with my home made build (10.5sdk/gcc4.2.1).

--> verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.