489411 - Disable Breakpad submission for non-official builds

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Once all is said and done and we're done testing, we need to disable Breakpad submission in non-official builds, since they won't be uploading symbols and they're unofficial ;)

However, we need to make sure that it's fairly easy for us to override this in order to be able to test new patches or Breakpad upgrades locally before landing.

Comment 1

[Stuart Morgan]

Attachment: fix

This uses the same approach we use for Sparkle: we only insert the URL into the plist in an official build, and we don't enable it if the URL is empty.

This includes Ilya's fix in bug 492387 since they can't really be separated and there's no harm in landing them together.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'd like to block b3 on this, if for some reason it's still waiting once we have an open tree again.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

In the long run, it might be good to figure out a way to disable Breakpad submission by default on hourlies, too (that same 09 hourly has two more crashes again today); I can file a low-priority follow-up on that once this lands.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 379375 [details] [diff] [review]
fix

sr=pink

Comment 5

[Stuart Morgan]

Landed on CVS trunk.

Comment 6

[Stuart Morgan]

Sigh. The patch (and thus the checkin) missed the Info-Camino.plist.in change to actually use %BREAKPAD_UPLOAD_URL% as the value.

Landed on CVS trunk, so this should actually work now.

Comment 7

[philippe (part-time)]

After rebuilding with the additional checkin from comment 6, no more Breakpad reporters with my home made build (10.5sdk/gcc4.2.1).

--> verified.