489511 - gfxFontCache will never hit on Freetype2 backend.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Takuro Ashie [:ashie]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8 (.NET CLR 3.5.30729)
Build Identifier: 

gfxFontCache::Lookup() requires font "face" name to lookup a font, but gfxFT2Font uses this function with font "family" name.

  https://hg.mozilla.org/mozilla-central/file/824f4ab3bfec/gfx/thebes/src/gfxFT2Fonts.cpp#l254

So that cache will never hit on this backend. I confirmed it on WinCE platform. I'm not sure but it will be caused also on other platforms which uses freetype2 backend.

gfxWindowsFont uses FontEntry::Name() to obtain font "face" name:

  https://hg.mozilla.org/mozilla-central/file/824f4ab3bfec/gfx/thebes/src/gfxWindowsFonts.cpp#l1186
  https://hg.mozilla.org/mozilla-central/file/824f4ab3bfec/gfx/thebes/public/gfxFont.h#l178

I think this is the correct way to lookup font cache.


Reproducible: Always

Comment 1

[Takuro Ashie [:ashie]]

Attachment: A patch to fix font cache issue

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 374008 [details] [diff] [review]
A patch to fix font cache issue

This seems a sensible solution to me, thank you.

(Naming font entries by face name seems sensible.  If we want gfxFontCache::GetCache()->Lookup() to work with a family name we'd have to also store the family name somewhere.)

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/fa0668077901