Closed
Bug 489580
Opened 16 years ago
Closed 16 years ago
Whitespace cleanup customizeToolbar.{js|xul} files
Categories
(Toolkit :: Toolbars and Toolbar Customization, defect)
Toolkit
Toolbars and Toolbar Customization
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file, 1 obsolete file)
|
13.80 KB,
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
While working on Bug 476814 I noticed a lot of trailing whitespace.
|
Assignee | |
Comment 1•16 years ago
|
||
Trivial whitespace removal. No code changes.
Attachment #374071 -
Flags: review?(mano)
|
||
Comment 2•16 years ago
|
||
The fixed1.9.1 keyword is wrong here, isn't it?
|
|
Assignee | |
Comment 3•16 years ago
|
||
> The fixed1.9.1 keyword is wrong here, isn't it?
Yah. I missed removing that when I cloned the bug.
Keywords: fixed1.9.1
|
||
Comment 4•16 years ago
|
||
Comment on attachment 374071 [details] [diff] [review]
Patch v1.0 Remove trailing whitespace.
You don't need review for this kind of changes.
Attachment #374071 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
patching file toolkit/content/customizeToolbar.js
Hunk #1 FAILED at 90
Hunk #14 FAILED at 751
Hunk #15 FAILED at 776
Hunk #16 FAILED at 804
Hunk #17 FAILED at 855
Hunk #18 FAILED at 887
Hunk #19 FAILED at 913
Hunk #20 FAILED at 944
Hunk #21 FAILED at 968
9 out of 21 hunks FAILED
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•16 years ago
|
||
Sigh. Fixed bit-rot. Carrying forward r+ from mano.
Attachment #374071 -
Attachment is obsolete: true
Attachment #384388 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•