Closed Bug 489710 Opened 11 years ago Closed 11 years ago

byteswap optimize for MSVC++

Categories

(NSS :: Libraries, defect, P3)

3.12.3
All
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.12.4

People

(Reporter: m_kato, Assigned: julien.pierre)

Details

(Whiteboard: FIPS)

Attachments

(1 file)

Attached patch patch v1Splinter Review
By bug 431958, although I make a patch for GCC, I forgot it for MSVC.
DES built by VC++ will improve 2-3% by this patch and reduce a few code size due to using bswap instruction.
Attachment #374196 - Flags: review?(julien.pierre.boogz)
Comment on attachment 374196 [details] [diff] [review]
patch v1

This is fine, but checkin will have to wait until we are unfrozen for FIPS.
Attachment #374196 - Flags: review?(julien.pierre.boogz) → review+
Whiteboard: FIPS [Awaiting Softoken's Thaw]
Assignee: nobody → julien.pierre.boogz
Priority: -- → P3
Version: trunk → 3.12.3
Target Milestone: --- → 3.12.4
Checking in des.c;
/cvsroot/mozilla/security/nss/lib/freebl/des.c,v  <--  des.c
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: FIPS [Awaiting Softoken's Thaw] → FIPS
You need to log in before you can comment on or make changes to this bug.