489779 - Crash [@ nsMsgSendLater::DoShutdownTask(nsIUrlListener*, nsIMsgWindow*, int*) ] whilst sending mail on shutdown

Status: VERIFIED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Found during TB's test day:

1) Have a message in the outbox whilst starting up Thunderbird.
2) Thunderbird prompts to send message, select Yes.
3) Quit whilst message is being sent.

Result: We crash.

0  	thunderbird.exe  	nsMsgSendLater::DoShutdownTask  	 mailnews/compose/src/nsMsgSendLater.cpp:1431
1 	thunderbird.exe 	nsMsgShutdownService::ProcessNextTask 	mailnews/base/src/nsMsgMailSession.cpp:562
2 	thunderbird.exe 	nsMsgShutdownService::StartShutdownTasks 	mailnews/base/src/nsMsgMailSession.cpp:697
3 	xpcom_core.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
4 	thunderbird.exe 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2480
5 	thunderbird.exe 	XPC_WN_CallMethod 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1587
6 	js3250.dll 	js_Invoke 	js/src/jsinterp.cpp:1380 

This is because mTimer is null at that stage and needs a null check.

Patch attached, I probably didn't need to bullet proof the Observe function, but thought I would do it just in case.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Breakpad stack URL:

bp-accd8b6a-f80a-476f-9579-273192090423

Comment 2

[Mark Banner (:standard8)]

Patch checked in: http://hg.mozilla.org/comm-central/rev/98ac44647507

Comment 3

[Wayne Mery (:wsmwk)]

nice - one more shutdown bug gone!
WFM Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b5pre) Gecko/20090505 Shredder/3.0b3pre (but I didn't test build before the patch)
v.fixed and bump severity

(In reply to comment #1)
> Breakpad stack URL:
> 
> bp-accd8b6a-f80a-476f-9579-273192090423

that's the only crash on crash-stats, build 20090422