Closed
Bug 489918
Opened 16 years ago
Closed 16 years ago
Add keyboard shortcut for selecting all files in downloads window
Categories
(Camino Graveyard :: Downloading, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ishermandom+bugs, Assigned: ishermandom+bugs)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
1.91 KB,
patch
|
ishermandom+bugs
:
superreview+
|
Details | Diff | Splinter Review |
We should wire up cmd-a to select all downloads in the downloads window.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #374391 -
Flags: review?(stuart.morgan+bugzilla)
|
|
||
Comment 2•16 years ago
|
||
Thanks for filing that; I meant to file that months ago and forgot.
|
|
Assignee | |
Updated•16 years ago
|
Summary: Add keyboard shortcut for selected all files in downloads window → Add keyboard shortcut for selecting all files in downloads window
|
||
Comment 3•16 years ago
|
||
Comment on attachment 374391 [details] [diff] [review]
Patch
r=me
Attachment #374391 -
Flags: superreview?(mikepinkerton)
Attachment #374391 -
Flags: review?(stuart.morgan+bugzilla)
Attachment #374391 -
Flags: review+
|
|
||
Comment 4•16 years ago
|
||
+-(void)selectDownloads:(NSArray*)downloads
function-level comment?
+ unsigned count = [downloads count];
I thought this usage (unsigned, w/out a length) was deprecated. Can you provide the full type? Also, make it const.
sr=pink with these addressed
|
|
||
Updated•16 years ago
|
Attachment #374391 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Addresses sr comments. Moved |selectDownloads| into |selectAll| since I think that is the only place where that code is actually useful.
Attachment #374391 -
Attachment is obsolete: true
Attachment #377613 -
Flags: superreview+
Landed on cvs trunk.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•