489922 - Selectively print heaprep for -memstats: reduces annoyance, improves performance

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P4)

Description

[Rishit Shah]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5
Build Identifier: 

The bitmap of used/unused pages generated in GCHeap::DumpMemoryInfo() might not be of interested to everyone.

The request is to move that info towards end of the report.

Should be as simple as calling DumpHeapReap() after DumpFatties()

Reproducible: Always

Comment 1

[Tommy Reilly]

+1 I'd like to add the detailed size class info and have that and DumpHeapRep turned off by default with a mechanism to enable.  Maybe we can piggy back on the existing GCHeapConfig.verbose flag and wire that up to a env var and the existing verbose command line switch.

Comment 2

[Rick Reitmaier]

-1 for env var and piggyback - knowledge will quickly be lost of how it works

+1 adding cmd line switch.

Comment 3

[Tommy Reilly]

env vars are nice for the player where command line isn't an option, to be sure there will be a cli switch.

Comment 4

[Lars T Hansen]

Targeting for 10.1 because the bitmap printout is seriously annoying for casual use of -memstats.

Comment 6

[Lars T Hansen]

Attachment: Simple fix

Comment 7

[Lars T Hansen]

redux changeset:   2744:54328be1b334