489938 - allow redirecting dump() to a file

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: dump to file

A lot of our tools rely on dump() for output, which makes it hard to get at the data on devices where we don't really have a stdout.  Here's a simple patch that adds a pref to optionally redirect dump() output to a file.

With this, and the ability to execute commands remotely with a command line (e.g. for winmo/wince, using rapi tools prun/pput/pget), we can run many of our tests on mobile devices.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 374405 [details] [diff] [review]
dump to file

+    const nsAdoptingCString& fname = 
+      nsContentUtils::GetCharPref("browser.dom.window.dump.file");
+    if (fname) {

That should be if (!fname.IsEmpty()) rather than just checking if (fname), right?

r+sr=jst

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: updated patch

Updated patch -- this correctly closes the file only in ::ShutDown instead of in ::Cleanup, giving us a new file per run correctly.  Also uses fputs() and adds a fflush() in dump() to ensure that the output always ends up in the file.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/49f4101fb09b

thanks!