489954 - Missing complete mars for localised 3.5b4

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We're uploading the archive (exe/dmg/tar.bz2) and xpi, but not the complete mar. This code snippet
 http://mxr.mozilla.org/mozilla1.9.1/source/browser/locales/Makefile.in#436
reveals the problem to be that we're not setting MOZ_MAKE_COMPLETE_MAR=1

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Temporary fix

This is the quick and dirty way to fix this, and we can come up with something that doesn't duplicate code later.

committed changeset 260:837b81bd8c36, r=bustage

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Better fix

This is a better fix I think. It sets the three packaging env. vars in the init rather than in the doRepack and doUpload. Originally I had just moved MOZ_MAKE_COMPLETE_MAR, but had a problem when uploading a 3.5rc1 test where I needed MOZ_PKG_VERSION too. The automation was trying to upload firefox-3.5.tar.bz2 instead of firefox-3.5.tar.bz2.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 377330 [details] [diff] [review]
Better fix

Yeah, I like this fix better too.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 377330 [details] [diff] [review]
Better fix

http://hg.mozilla.org/build/buildbotcustom/rev/3d4c6dde70a9

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

production-master reconfig'd.