Closed Bug 489954 Opened 11 years ago Closed 11 years ago

Missing complete mars for localised 3.5b4

Categories

(Release Engineering :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(2 files)

We're uploading the archive (exe/dmg/tar.bz2) and xpi, but not the complete mar. This code snippet
 http://mxr.mozilla.org/mozilla1.9.1/source/browser/locales/Makefile.in#436
reveals the problem to be that we're not setting MOZ_MAKE_COMPLETE_MAR=1
Blocks: 486459
Priority: -- → P1
Attached patch Temporary fixSplinter Review
This is the quick and dirty way to fix this, and we can come up with something that doesn't duplicate code later.

committed changeset 260:837b81bd8c36, r=bustage
Attachment #374439 - Flags: checked‑in+
Priority: P1 → P2
Attached patch Better fixSplinter Review
This is a better fix I think. It sets the three packaging env. vars in the init rather than in the doRepack and doUpload. Originally I had just moved MOZ_MAKE_COMPLETE_MAR, but had a problem when uploading a 3.5rc1 test where I needed MOZ_PKG_VERSION too. The automation was trying to upload firefox-3.5.tar.bz2 instead of firefox-3.5.tar.bz2.
Attachment #377330 - Flags: review?(bhearsum)
Comment on attachment 377330 [details] [diff] [review]
Better fix

Yeah, I like this fix better too.
Attachment #377330 - Flags: review?(bhearsum) → review+
production-master reconfig'd.
Blocks: 433930
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.