Remembering focus on add bookmarks dialog can have wrong behavior




Bookmarks & History
9 years ago
10 months ago


(Reporter: mak, Unassigned)


Windows Vista

Firefox Tracking Flags

(Not tracked)


from bug 480151
(In reply to comment #13)
> I have a doubt on this patch now, you set the pref in editItemOverlay, but use
> it only in the StarUI. there's no risk that other users of editItemOverlay
> (bookmarks properties dialog and the Library) could change the setting so that:
> - in star UI you focus tags first so reopening star ui it will be focused
> - you add a livemark, the dialog uses editItemOverlay, and you change name
> first because you can't tag a livemark. Same would be if you bookmark all tabs,
> or right click and choose New bookmark (hardly you will go to tags before
> filing a name there)
> - next time you will open star UI it will focus name field even if you want it
> to focus tags field.
> I guess if this code should live completely in StarUI object instead, and use
> listeners.
Blocks: 480151
blindly assigning to Mano since he said was working on fixing the behavior.
Feel free to reassign if i'm wrong.
Assignee: nobody → mano
Blocks: 407366
I'm not sure that this issue should block us from making the change in Firefox 3.5, to be honest. Is that the only problem with the patch in bug 480151? If so, I'd say let's keep this as a post-3.5 followup, and make the behaviour mostly-better for 3.5!
No longer blocks: 407366
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Assignee: asaf → nobody
You need to log in before you can comment on or make changes to this bug.