490047 - findbar widget should call preventDefault() for VK_RETURN keypress event

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[Wladimir Palant]

In a dialog, the default action on VK_RETURN is to accept (close) the dialog. Currently, this action is also triggered if the user presses VK_RETURN inside the findbar widget - which is supposed to trigger "Find again" instead. In Adblock Plus I had to add this code to work around:

  E("findbar").addEventListener("keypress", function(event)
  {
    if (event.keyCode == KeyEvent.DOM_VK_RETURN)
      event.preventDefault();
  }, false);

It would be better if the widget would call event.preventDefault() itself instead - for example in _handleEnter() method.

Comment 1

[Wladimir Palant]

It seems that `<findbar>` isn't meant to be a reusable widget, despite being in Toolkit.

Comment 2

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336