490070 - clicking on a link in XUL (className="text-link") opens a new window, not a new tab

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

if you have a link in xul (eg. Learn More... in the geolocation notification), when the user clicks on it, a new windows is opened.  This should really be a new tab.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The generic bug for this in toolkit is bug 263433. I suppose we can work around it fairly easily in Fennec by using onclick instead of href, and calling our own addTab (or whatever).

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> The generic bug for this in toolkit is bug 263433. I suppose we can work around
> it fairly easily in Fennec by using onclick instead of href, and calling our
> own addTab (or whatever).

Agreed. Toolkit checks the originating window and, if chrome, it always opens in a new window.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Shouldn't bug 263433 be the blocking? bug?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I'm not sure of what we have change in our code but actually the "Learn more..." seems to open a new tab in my case

Comment 5

[Aakash Desai [:aakashd]]

This works for me on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091209 Firefox/3.6b5pre Fennec/1.0b6pre

Comment 6

[Doug Turner (:dougt)]

We have a workaround onclick handler that avoids opening a new window:

http://mxr.mozilla.org/mobile-browser/source/chrome/content/notification.xml#105


This bug intent is to remove our workaround when 263433 is fixed.  Given that we have a work around, this shouldn't block.

Comment 7

[Doug Turner (:dougt)]

This year we mothballed windows mobile development.  See:

  http://blog.pavlov.net/2010/03/22/stopping-development-for-windows-mobile/

Marking bugs in the windows mobile / windows ce bucket as WONTFIX.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

not a wince bug

Comment 9

[BMO Automation]

Closing all opened bug in a graveyard component