490149 - Switch to mail/config/version.txt on the MOZILLA_1_8_BRANCH

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I noticed when the first bug was filed with 1.6.7 that our "like Firefox/$VER" had a "pre" version instead of a stable app version.

Arguably it's a MoCo bug that the Firefox version is not bumped on the Gecko relbranch (for which Tb is now the primary consumer) where the code is still used for distro Firefox releases, but the path of least resistance is for us to just switch what FOX_APP_VERSION_FILE points to.

This assumes that we want to have a stable $VER in the "like Firefox" string in stable releases, of course, and I think we do.

Comment 1

[Chris Lawson (gone)]

Ping. Stuart, should we just go ahead and confirm this?

Comment 2

[Stuart Morgan]

Sure? I've never paid attention to this part of the build system, but whatever works best for our versioning.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Pull Tb version on MOZILLA_1_8_BRANCH now that Firefox is never non-pre

I think we should have a non-pre version number everywhere for our release versions based on stable Geckos, and short of repeatedly making minibranch checkins to files we don't own (which is a pain, anyway), this is the best way to achieve that.

I don't know for positive that people are checking for the presence/absence of "pre" when doing their silly version checks, but I'd rather not introduce "pre"-confusion into release builds.

Comment 4

[Stuart Morgan]

Comment on attachment 379504 [details] [diff] [review]
Pull Tb version on MOZILLA_1_8_BRANCH now that Firefox is never non-pre

sr=smorgan

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH in advance of Camino 1.6.8.