490154 - Cryptokey framework requires module to implement GenerateKey when they support KeyPairGeneration

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Elio Maldonado]

In lib/ckfw/mechanism.c the nssCKFWMechanism_GenerateKeyPair function
has the following test early on
  if (!fwMechanism->mdMechanism->GenerateKey) {
    return CKR_FUNCTION_FAILED;
  }
It is conceivable for a pkcs #11 module to support key pair generation without supporting secret key generation. The PEM module with write support added would be such a module.
It seems to me that the test want meant to be (and should be)
  if (!fwMechanism->mdMechanism->GenerateKeyPair) {
    return CKR_FUNCTION_FAILED;
  }

Comment 1

[Elio Maldonado]

Attachment: Fix function pointer test in nssCKFWMechanism_GenerateKeyPair

Comment 2

[Robert Relyea]

Comment on attachment 374609 [details] [diff] [review]
Fix function pointer test in nssCKFWMechanism_GenerateKeyPair

r+ Looks like you found a real bug. It should have been generateKeyPair from the beginning.

bob

Comment 3

[Elio Maldonado]

Checking in mechanism.c;
/cvsroot/mozilla/security/nss/lib/ckfw/mechanism.c,v  <--  mechanism.c
new revision: 1.7; previous revision: 1.6