display:table-row elements that become adjacent should merge into one anonymous table

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jruderman, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug, {testcase})

Trunk
x86
Mac OS X
testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Created attachment 374667 [details]
testcase (dynamic)

Based on reftests from bug 478956.
(Reporter)

Comment 1

10 years ago
Created attachment 374668 [details]
reference (static)
(Assignee)

Comment 2

10 years ago
Created attachment 374728 [details] [diff] [review]
Fix

We even had code for this case, but I'd only tested it in cases where I was removing a textnode (which therefore absorbed all the whitespace) or where I was removing kids of table-display stuff (so there were not frames for the whitespace around).  The reftests test the same thing as the attached testcase for table rows and table row groups, fail without this patch, pass with.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #374728 - Flags: superreview?(roc)
Attachment #374728 - Flags: review?(roc)
(Assignee)

Comment 3

10 years ago
Created attachment 374729 [details] [diff] [review]
Even including the reftests
Attachment #374728 - Attachment is obsolete: true
Attachment #374729 - Flags: superreview?(roc)
Attachment #374729 - Flags: review?(roc)
Attachment #374728 - Flags: superreview?(roc)
Attachment #374728 - Flags: review?(roc)
Attachment #374729 - Flags: superreview?(roc)
Attachment #374729 - Flags: superreview+
Attachment #374729 - Flags: review?(roc)
Attachment #374729 - Flags: review+
(Assignee)

Comment 4

10 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/696dbbd73355
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.