Closed Bug 490220 Opened 13 years ago Closed 13 years ago

display:table-row elements that become adjacent should merge into one anonymous table

Categories

(Core :: Layout: Tables, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: testcase)

Attachments

(3 files, 1 obsolete file)

Attached file testcase (dynamic)
Based on reftests from bug 478956.
Attached file reference (static)
Attached patch Fix (obsolete) — Splinter Review
We even had code for this case, but I'd only tested it in cases where I was removing a textnode (which therefore absorbed all the whitespace) or where I was removing kids of table-display stuff (so there were not frames for the whitespace around).  The reftests test the same thing as the attached testcase for table rows and table row groups, fail without this patch, pass with.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #374728 - Flags: superreview?(roc)
Attachment #374728 - Flags: review?(roc)
Attachment #374728 - Attachment is obsolete: true
Attachment #374729 - Flags: superreview?(roc)
Attachment #374729 - Flags: review?(roc)
Attachment #374728 - Flags: superreview?(roc)
Attachment #374728 - Flags: review?(roc)
Attachment #374729 - Flags: superreview?(roc)
Attachment #374729 - Flags: superreview+
Attachment #374729 - Flags: review?(roc)
Attachment #374729 - Flags: review+
Pushed http://hg.mozilla.org/mozilla-central/rev/696dbbd73355
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.