490374 - Input (type="button") and buttons with a background image should have a context menu

Status: NEW

(Firefox :: Menus, enhancement)

Description

[Nochum Sossonko [:Natch]]

Attachment: youtube-style image

For all the same reasons in bug 424101 and because to the user this looks the same as a regular image, for consistency this should be enabled.

See the url (yes, youtube) the logo image is unreachable.

Comment 1

[Nochum Sossonko [:Natch]]

Attachment: patch w/test

Had to move the check down a bit as it was being overriden by the variables set after the call to isTargetAFormControl.

I'm not even sure why those values are being reset there, isn't there a new nsContextMenu for every click? If so, all those values are already being set in the constructor, so it's Just Weird.

Added a test to an existing test file, renamed it et al.

Comment 2

[Nochum Sossonko [:Natch]]

Oh, forgot to mention, the change to getComputedURL was necessary as the call would result in a CSSValueList, the first item being the url...

Comment 3

[Nochum Sossonko [:Natch]]

Comment on attachment 395513 [details] [diff] [review]
patch w/test

Gonna revise a bit, which will include a fix for bug 287048.

Comment 4

[Nochum Sossonko [:Natch]]

Attachment: patch

Ok, fixes this and the dependent bug, right-clicks that aren't over actual links (or the actual links child) will allow still for background image viewing. For this bug, inputs and buttons with background images will sprout the background-image context menu.

Comment 5

[Nochum Sossonko [:Natch]]

Attachment: updated to tip + some fixes

Updated to catch some bitrot, also fixed a small mistake.

Comment 6

[Nochum Sossonko [:Natch]]

Ping. Any chance of getting a review here?

Comment 7

[Nochum Sossonko [:Natch]]

->default