490468 - Tidy up some leaks in mailnews tests

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I've been playing around a bit with our unit tests and just seeing what leaks we are getting.

I noticed that our imap tests were quite leaky especially wrt the protocol. It turns out that we are currently typically calling closeCachedConnections from the onStopRequest of a urlListener.

Unfortunately this means we're still in the middle of a connection, and hence the connection doesn't get tidied up correctly. The simple fix is to close the cached connections after a short timeout.

Note: this isn't the code that is leaking, just our unit test methods causing it to leak.

Even after this fix (and the one from bug 438922) we aren't free of reported leaks (e.g. rdf service/resources, other random happenings). However it still helps to clear up the picture a bit.

I've also removed one function: nsImapServerResponseParser::GetHostSessionList its not used and probably would have leaked had anyone tried to use it (return type should have been already_AddRefed<nsIImapHostSessionList>).

Comment 1

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/17bb312af3ba