Closed
Bug 490561
Opened 15 years ago
Closed 15 years ago
Update gfxOS2Fonts::GetMetrics
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
status1.9.1 | --- | .4-fixed |
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
Attachments
(2 files)
9.03 KB,
patch
|
Details | Diff | Splinter Review | |
521.57 KB,
application/zip
|
Details |
Apparently the metrics structure in Thebes was updated some time ago with a few new members. gfxPangoFonts now uses plenty of heuristics to get better display. We should look through these for OS/2.
Assignee | ||
Comment 1•15 years ago
|
||
As I just posted to the newsgroup, it seems that one should use the x-advance property instead of the glyph width for all horizontal metrics. That's how one should change the computation of the aveCharWidth property.
I also wonder, if we should round the emHeight of all fonts to a integer number of pixels. That is what apparently happens on the other platforms. That might then also influence the problem reported in bug 439195.
Assignee | ||
Comment 2•15 years ago
|
||
I have worked myself through the GetMetrics used in gfxPangoFonts now and some of the tricks used there are nice, but I don't want to take all of it because it's pretty convoluted (sometimes without obvious reasons).
The emHeight-integer trick does _not_ help the chrome font issue of bug 439195, though. That's because 9pt always scale to integer pixels anyway (either 9.*96./72.=12.00 or 9.*120./72.=15.00).
Assignee | ||
Comment 3•15 years ago
|
||
OK, I think this does it.
Assignee | ||
Comment 4•15 years ago
|
||
This is the DLL for testing, meant to be used together with the still-current nightly at <http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/contrib/2009/08/2009-08-09-03-comm-1.9.1/>.
As one can see, even if using the broken Workplace Sans v0.4 created with TypeTool v3 that Alex posted some time ago, the entry fields in the prefs now get a useful size.
Assignee | ||
Comment 5•15 years ago
|
||
Didn't see any problems on my system, heard no complaints, so I pushed this:
http://hg.mozilla.org/mozilla-central/rev/f11ffc7eaeff
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/bc28ac5281e4
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4470654d36cb
(It doesn't help with the 96dpi problem, though.)
No longer blocks: 439195
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
status1.9.1:
--- → .4-fixed
Keywords: fixed1.9.2
Resolution: --- → FIXED
Updated•15 years ago
|
status1.9.2:
--- → beta1-fixed
Keywords: fixed1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•