490562 - QuickSearch "+" operator adds $qsword over and over for @subWords

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Max Kanat-Alexander]

From QuickSearch.pm:

     if ($firstChar eq '+') {
         foreach (@subWords) {
             addChart('short_desc', 'substring', $qsword, $negate);
         }
         return 1;
     }

That doesn't look right--why add $qsword over and over?

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This looks like the fix to me.

Comment 2

[Frédéric Buclin]

Regression due to bug 70907, i.e. since 2.22. The code in the original JS file
seems correct.

Comment 3

[Frédéric Buclin]

Comment on attachment 374965 [details] [diff] [review]
v1

Looks good and works as expected. r=LpSolit

Comment 4

[Max Kanat-Alexander]

tip:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.23; previous revision: 1.22
done

3.4:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.22.2.1; previous revision: 1.22
done

3.2:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.20.2.3; previous revision: 1.20.2.2
done