490649 - Ampersand usage should be consistent in clear recent history dialog [en-US]

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Drew Willcoxon :adw]

The recent clear recent history dialog refresh (bug 480169) uses the strings "Browsing and Download History" and "Form & Search History".  "Browsing and Download History" should use an ampersand.

Not sure if there's consensus on whether this needs an entity name change.  I'll attach two patches, one with, one without.

Comment 1

[Axel Hecht [:Pike]]

The consensus is that we don't rev the entity name, and just post to .l10n about that change.

Comment 2

[Drew Willcoxon :adw]

Attachment: patch, no entity name change

Thanks, Axel.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 375045 [details] [diff] [review]
patch, no entity name change

r=me, additional review request on beltzner to follow the process from .planning.

Comment 4

[Drew Willcoxon :adw]

Dao, you've been changing all the depends-on-480169 relationships in this bug and others to blocking 480169.  I'm new here, so I might be misunderstanding how we use depends vs. blocking, but how does this bug block 480169?  That's completely backwards.  480169 is over and done with, and this bug and others depend on its changes.

Comment 5

[Dão Gottwald [:dao]]

There are two kinds of followup relations. One is "once bug 480169 is fixed, we can move forward with bug 490649" and the other is "bug 490649 is a leftover from or an issue with the fix for bug 480169". In the former case, bug 480169 would block bug 490649, in the latter case it's vice versa.

One could say that bug 480169 isn't over and done -- it will be over and done when its dependency tree is cleared (https://bugzilla.mozilla.org/showdependencytree.cgi?id=480169&hide_resolved=1).

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Yeah, bugzilla hasn't been ideal for this kind of tracking, but comment 5 reflects current best-practices. Hopefully bug 287334 will allow us to have real "regresses/regressed by" fields - I'm going to file a followup on doing that on b.m.o.

Comment 7

[Axel Hecht [:Pike]]

beltzner, do we want to take this? As said in comment 1, this is not a l10n-impact change to a file in en-US, and I'd be fine with taking it still.

Comment 8

[Johnathan Nightingale [:johnath]]

Comment on attachment 375045 [details] [diff] [review]
patch, no entity name change

Adding this to the approval queue.  We certainly don't need to block on it, but I think it's a good, and tiny, polish fix to a feature that we expect to highlight in this release.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 375045 [details] [diff] [review]
patch, no entity name change

a191=beltzner

Comment 10

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ec71535f279f

Comment 11

[Chris Ilias [:cilias]]

user-doc-complete
<https://support.mozilla.com/kb/Clear+Recent+History?bl=n>

Comment 12

[Drew Willcoxon :adw]

Ehsan, this was never pushed to trunk.  Could we do that?

Comment 13

[(no longer active)]

Sorry; I don't know why I assumed that it had already landed on trunk!

http://hg.mozilla.org/mozilla-central/rev/52c12a6e10b3

Comment 14

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre ID:20090526031623

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre ID:20090526031155