490657 - Submit URLs to Socorro

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We'll need to be able to submit crash URLs to Socorro.

I believe Firefox decided to use the last page loaded as the crashing URL, but I'd have to go find the bug again.

Note that URLs are not currently visible per-report, but they are aggregated into topcrash reports like the one in the URL field.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> I believe Firefox decided to use the last page loaded as the crashing URL, but
> I'd have to go find the bug again.

Bug 375083 comment 12

Comment 2

[Stuart Morgan]

It looks like the comment on
http://code.google.com/p/socorro/source/browse/trunk/socorro/processor/processor.py#585
is out of date (which is why I couldn't figure out how they were passing it before), and we just need to stuff it into a URL param. I think this can be done without more upstream changes after the last round of param support stuff in Breakpad; I'll take a look.

Comment 3

[Stuart Morgan]

The code I was thinking of is in flight; we need http://breakpad.appspot.com/8002/show for this. Then we'll need to wire Camino up to push URLs in.

What's our position on explicit consent though? I'd really rather not add UI where users have to opt in or out of this field. Is (lack of identifiability of crash reports) + (choice to submit a report) + (the fact that only logged in users will be able to see them in anything other than aggregate) sufficient?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think that it's probably safe for the foreseeable future, yes.  If login is ever implemented, we may need to reconsider.

(Given that we're going to need some sort of page for disclaimers and other stuff for safebrowsing, perhaps we should mention this, too?  c.f. http://www.mozilla.com/en-US/legal/privacy/firefox-en.html)

Comment 5

[Stuart Morgan]

Looks like the change I mentioned in comment 3 is going in soon. Note to self: when we update to get it, the way we specify the build id in the plist will need to change slightly.

Comment 6

[Stuart Morgan]

I've rev'd us to 366, which means we now have the library support for this. I just need to finish the code that pushes the current URL into breakpad.

Comment 7

[Stuart Morgan]

Attachment: fix

I believe that this should theoretically work, but I have no idea how to test that the Breakpad+Socorro part is working. Smokey, do you have any idea how we would find out (other than "ship it and see if we get top crash site info")? Is there someone with the magic power to look at, say:
http://crash-stats.mozilla.com/report/index/3a8ceb20-8677-4794-a26f-e7f5a2090907
and see if it has a URL?

I do know that we are at least calling the the BreakpadWrapper method at the right times:
- When the active tab changes
- When the active window changes
- When page loading starts
where "about:blank"/"" are filtered out. That seems like the same best-guess approach Firefox took.

Comment 8

[Stuart Morgan]

(In reply to comment #7)
> Smokey, do you have any idea how we would find out

Nevermind, thanks to the helpful folks in #breakpad I have an answer: it does indeed work :)

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 399158 [details] [diff] [review]
fix

+@interface BreakpadWrapper : NSObject {
+  void* mBreakpadReference;
+}

class-level comment on what this class does and why it's here.

sr=pink

Comment 10

[Stuart Morgan]

Landed on trunk and CAMINO_2_0_BRANCH with added comment.