Bug 490661 (asyncBookmarkBackups)

bookmark backups should be async

RESOLVED FIXED in mozilla28

Status

()

RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: dietrich, Unassigned)

Tracking

(Blocks: 1 bug, {meta, perf})

Trunk
mozilla28
meta, perf
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy:p2][qa-])

Comment hidden (empty)
(Reporter)

Updated

9 years ago
Whiteboard: [tsnap]
(Reporter)

Comment 1

7 years ago
hm, are these written on idle only?
nope, a backup may also be created on shutdown if there is no backup in the last 24 hours, this covers those cases where idle may not happen.
(Reporter)

Comment 3

7 years ago
ok, so if only on idle and possibly shutdown, this is a pretty low priority bug.
(Reporter)

Updated

7 years ago
Whiteboard: [tsnap] → [snappy]

Updated

7 years ago
Whiteboard: [snappy] → [snappy:p1]

Comment 4

7 years ago
Taras says we should not do shutdown IO here.
No doubts, still, if the user never hits idle, there isn't another place where to backup his data.
Please read above, this only happens if there is no backup in the last 24 hours, and backups are saved on idle wherever possible.

Btw, all the import/export/backup/restore code is pretty old and needs a rewrite (bug 549736 may be a good thing to do, if we read asynchronously and directly from the db and allow to store data in different formats).
Depends on: 549736

Comment 6

7 years ago
Why do we need to do a backup on shutdown. Reducing this to p2 since we don't have data on how often this happens
Whiteboard: [snappy:p1] → [snappy:p2]
(Reporter)

Comment 7

7 years ago
Yeah, definitely not P1. See above - we only backup on shutdown if the user never hit idle during previous session for a long enough time do to a backup *and* it's been >24hrs since previous backup.

Comment 8

7 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #7)
> Yeah, definitely not P1. See above - we only backup on shutdown if the user
> never hit idle during previous session for a long enough time do to a backup
> *and* it's been >24hrs since previous backup.

We could use telemetry to see how frequent this is.

Updated

6 years ago
Depends on: 763295

Updated

6 years ago
Blocks: 818587
Blocks: 819063

Updated

6 years ago
Blocks: 824433

Updated

6 years ago
No longer blocks: 819063
Depends on: 822200

Updated

5 years ago
Depends on: 859695

Updated

5 years ago
Depends on: 887043

Updated

5 years ago
Blocks: 699820
Summary: bookmark backups should write async → bookmark backups should be async

Updated

5 years ago
Alias: asyncBookmarkBackups
Blocks: 855226
We can consider the main-thread IO issue that was covered by this meta as fixed. Work on backups didn't finish, there's still lot of stuff to cleanup (like shutdown, backups hashes comparison...), but that has a smaller priority compared to the main-thread IO issue tracked here. It can proceed apart.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Keywords: meta

Updated

5 years ago
Whiteboard: [snappy:p2] → [snappy:p2][qa-]

Updated

5 years ago
Depends on: 852030
You need to log in before you can comment on or make changes to this bug.