Closed Bug 490661 (asyncBookmarkBackups) Opened 12 years ago Closed 7 years ago

bookmark backups should be async

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: dietrich, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: meta, perf, Whiteboard: [snappy:p2][qa-])

No description provided.
Whiteboard: [tsnap]
hm, are these written on idle only?
nope, a backup may also be created on shutdown if there is no backup in the last 24 hours, this covers those cases where idle may not happen.
ok, so if only on idle and possibly shutdown, this is a pretty low priority bug.
Whiteboard: [tsnap] → [snappy]
Whiteboard: [snappy] → [snappy:p1]
Taras says we should not do shutdown IO here.
No doubts, still, if the user never hits idle, there isn't another place where to backup his data.
Please read above, this only happens if there is no backup in the last 24 hours, and backups are saved on idle wherever possible.

Btw, all the import/export/backup/restore code is pretty old and needs a rewrite (bug 549736 may be a good thing to do, if we read asynchronously and directly from the db and allow to store data in different formats).
Depends on: 549736
Why do we need to do a backup on shutdown. Reducing this to p2 since we don't have data on how often this happens
Whiteboard: [snappy:p1] → [snappy:p2]
Yeah, definitely not P1. See above - we only backup on shutdown if the user never hit idle during previous session for a long enough time do to a backup *and* it's been >24hrs since previous backup.
(In reply to Dietrich Ayala (:dietrich) from comment #7)
> Yeah, definitely not P1. See above - we only backup on shutdown if the user
> never hit idle during previous session for a long enough time do to a backup
> *and* it's been >24hrs since previous backup.

We could use telemetry to see how frequent this is.
Depends on: 763295
Blocks: 818587
Blocks: 824433
No longer blocks: shutdown-faster
Depends on: 822200
Depends on: 859695
Depends on: 887043
Blocks: StorageJank
Summary: bookmark backups should write async → bookmark backups should be async
Alias: asyncBookmarkBackups
Blocks: 855226
We can consider the main-thread IO issue that was covered by this meta as fixed. Work on backups didn't finish, there's still lot of stuff to cleanup (like shutdown, backups hashes comparison...), but that has a smaller priority compared to the main-thread IO issue tracked here. It can proceed apart.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Keywords: meta
Whiteboard: [snappy:p2] → [snappy:p2][qa-]
Depends on: 852030
You need to log in before you can comment on or make changes to this bug.